fix: ensure ElectronBrowser mojo service is only bound to appropriate render frames #33367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trop
bot
added
16-x-y
backport
MarshallOfSound
force-pushed
the
subframe-ipc-16
branch
from
5ad0923
to
777287a
Compare
MarshallOfSound
dismissed
jkleinsc’s stale review
All builds are failing, please don't req changes when CI is red it just blocks merging later down the line
|
in other releases #32734 was merged before this change |
Co-authored-by: Marek Haranczyk <marek@openfin.co>
MarshallOfSound
force-pushed
the
subframe-ipc-16
branch
from
96bc64f
to
4d3b9a5
Compare
MarshallOfSound
force-pushed
the
subframe-ipc-16
branch
from
4d3b9a5
to
b702a4f
Compare
nornagon
approved these changes
May 4, 2022
|
No Release Notes |
MarshallOfSound
added a commit
that referenced
this pull request
May 11, 2022
… render frames (#33367) * Make ElectronBrowser mojo interface frame associated. (#32815) Co-authored-by: Marek Haranczyk <marek@openfin.co> * fix: ensure ElectronBrowser mojo service is only bound to appropriate render frames (#33323) (#33350) * fix: ensure ElectronBrowser mojo service is only bound to authorized render frames Notes: no-notes * refactor: extract electron API IPC to its own mojo interface * fix: just check main frame not primary main frame Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Marek Haranczyk <marek@openfin.co>
MarshallOfSound
added a commit
that referenced
this pull request
May 12, 2022
… render frames (#34191) fix: ensure ElectronBrowser mojo service is only bound to appropriate render frames (#33367) * Make ElectronBrowser mojo interface frame associated. (#32815) Co-authored-by: Marek Haranczyk <marek@openfin.co> * fix: ensure ElectronBrowser mojo service is only bound to appropriate render frames (#33323) (#33350) * fix: ensure ElectronBrowser mojo service is only bound to authorized render frames Notes: no-notes * refactor: extract electron API IPC to its own mojo interface * fix: just check main frame not primary main frame Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Marek Haranczyk <marek@openfin.co> Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Marek Haranczyk <marek@openfin.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #33323
Also backports #32734
Notes: no-notes