Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: initialize asar support in worker threads #33396

Commits on Mar 23, 2022

  1. fix: initialize asar support in worker threads (#33216)

    * fix: initialize asar support in worker threads
    
    Use `ObjectWrap` instead of gin's Wrap in `electron_api_asar.cc` because
    gin isn't fully initialized (and apparently not possible to initialize
    without ruining the isolate configuration and array buffer allocator) in
    worker threads. In the worker thread call `setupAsarSupport` just as we
    do for the main process.
    
    * Update lib/asar/fs-wrapper.ts
    
    Co-authored-by: Darshan Sen <raisinten@gmail.com>
    
    * Update patches/node/worker_thread_add_asar_support.patch
    
    Co-authored-by: Darshan Sen <raisinten@gmail.com>
    
    * Add a test
    
    Co-authored-by: Darshan Sen <raisinten@gmail.com>
    Co-authored-by: Fedor Indutny <79877362+indutny-signal@users.noreply.github.com>
    Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
    4 people authored and electron-bot committed Mar 23, 2022
    Copy the full SHA
    e5e4292 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2022

  1. Merge branch '18-x-y' into trop/18-x-y-bp-fix-initialize-asar-support…

    …-in-worker-threads-1647995891427
    jkleinsc committed Mar 24, 2022
    Copy the full SHA
    652ab1e View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    4a7f3f3 View commit details
    Browse the repository at this point in the history