Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gn check when //printing component is disabled #33601

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Apr 4, 2022

Backport of #33429

See that PR for details.

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 4, 2022
@trop trop bot requested a review from deepak1556 April 4, 2022 18:16
@trop trop bot added 15-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Apr 4, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 4, 2022
@miniak miniak mentioned this pull request Apr 4, 2022
2 tasks
@nornagon
Copy link
Member

nornagon commented Apr 4, 2022

#33523 is the cause of the failing test; merging.

@nornagon nornagon merged commit 8279c02 into 15-x-y Apr 4, 2022
@nornagon nornagon deleted the trop/15-x-y-bp-fix-gn-check-when-printing-component-is-disabled-1649096194207 branch April 4, 2022 23:39
@release-clerk
Copy link

release-clerk bot commented Apr 4, 2022

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
15-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants