Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick f599381978f2 from v8 #33606

Merged
merged 2 commits into from Apr 5, 2022

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Apr 4, 2022

[M96-LTS][runtime] Fix handling of interceptors, pt.3

... in JSObject::DefineOwnPropertyIgnoreAttributes().
Don't execute interceptor again if it declined to handle the operation.

(cherry picked from commit c4e66b89b4ecd0e90b31e9e4ed08d38085a84c49)

Bug: chromium:1311641
No-Try: true
No-Presubmit: true
No-Tree-Checks: true
Change-Id: Ie9aef5a98959403f6a26e6bef7f4a77d312bd62a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3568921
Reviewed-by: Lutz Vahl vahl@chromium.org
Reviewed-by: Igor Sheludko ishell@chromium.org
Commit-Queue: Igor Sheludko ishell@chromium.org
Cr-Commit-Position: refs/branch-heads/9.6@{#56}
Cr-Branched-From: 0b7bda016178bf438f09b3c93da572ae3663a1f7-refs/heads/9.6.180@{#1}
Cr-Branched-From: 41a5a247d9430b953e38631e88d17790306f7a4c-refs/heads/main@{#77244}

Notes: Security: backported fix for chromium:1311641.

@nornagon nornagon requested review from a team as code owners April 4, 2022 21:14
@nornagon nornagon added 15-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes labels Apr 4, 2022
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Apr 4, 2022
@nornagon
Copy link
Member Author

nornagon commented Apr 5, 2022

#33523 is the cause of the failing tests on Windows.

@nornagon nornagon merged commit 2c3081a into 15-x-y Apr 5, 2022
@nornagon nornagon deleted the cherry-pick/15-x-y/v8/f599381978f2 branch April 5, 2022 16:42
@release-clerk
Copy link

release-clerk bot commented Apr 5, 2022

Release Notes Persisted

Security: backported fix for chromium:1311641.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
15-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants