Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: printToPDF should be headless #33654

Merged
merged 30 commits into from May 31, 2022
Merged

refactor: printToPDF should be headless #33654

merged 30 commits into from May 31, 2022

Commits on May 24, 2022

  1. refactor: use headless approach to printToPdf

    @codebytere
    codebytere committed May 24, 2022
    Configuration menu
    Copy the full SHA
    e5ef623 View commit details
    Browse the repository at this point in the history

  2. fix: actually resolve pdf data

    @codebytere
    codebytere committed May 24, 2022
    Configuration menu
    Copy the full SHA
    e0482e6 View commit details
    Browse the repository at this point in the history

  3. fix: reject properly when PDFgeneration fails

    @codebytere
    codebytere committed May 24, 2022
    Configuration menu
    Copy the full SHA
    9f74948 View commit details
    Browse the repository at this point in the history

  4. refactor: subclass PrintViewManager

    @codebytere
    codebytere committed May 24, 2022
    Configuration menu
    Copy the full SHA
    081d304 View commit details
    Browse the repository at this point in the history

  5. fix: pdf generation & some settings

    @codebytere
    codebytere committed May 24, 2022
    Configuration menu
    Copy the full SHA
    852e3b0 View commit details
    Browse the repository at this point in the history

  6. chore: remove unused includes

    @codebytere
    codebytere committed May 24, 2022
    Configuration menu
    Copy the full SHA
    bc22863 View commit details
    Browse the repository at this point in the history

  7. chore: nevermind, we're gonna subclass PrintViewManagerBase

    @codebytere
    codebytere committed May 24, 2022
    Configuration menu
    Copy the full SHA
    cb9a6d1 View commit details
    Browse the repository at this point in the history

  8. chore: add back mojo bad message calls

    @codebytere
    codebytere committed May 24, 2022
    Configuration menu
    Copy the full SHA
    34ad458 View commit details
    Browse the repository at this point in the history

  9. refactor: use proper print job constants

    @codebytere
    codebytere committed May 24, 2022
    Configuration menu
    Copy the full SHA
    5589442 View commit details
    Browse the repository at this point in the history

  10. fix: don't run invalid mojom::PrintParamsPtr

    @codebytere
    codebytere committed May 24, 2022
    Configuration menu
    Copy the full SHA
    cee5984 View commit details
    Browse the repository at this point in the history

  11. fix: call PrintViewManagerBase' RenderFrameDeleted

    @codebytere
    codebytere committed May 24, 2022
    Configuration menu
    Copy the full SHA
    4467b56 View commit details
    Browse the repository at this point in the history

  12. fix: broken window.print()

    @codebytere
    codebytere committed May 24, 2022
    Configuration menu
    Copy the full SHA
    fd4022f View commit details
    Browse the repository at this point in the history

  13. refactor: snap to Page.printToPDF settings

    @codebytere
    codebytere committed May 24, 2022
    Configuration menu
    Copy the full SHA
    310a5b0 View commit details
    Browse the repository at this point in the history

  14. fix: remove pdf job from vector on completion

    @codebytere
    codebytere committed May 24, 2022
    Configuration menu
    Copy the full SHA
    484a338 View commit details
    Browse the repository at this point in the history

  15. fix: don't create composite client

    @codebytere
    codebytere committed May 24, 2022
    Configuration menu
    Copy the full SHA
    90dd7a7 View commit details
    Browse the repository at this point in the history

  16. fix: don't drop support for pageSize

    @codebytere
    codebytere committed May 24, 2022
    Configuration menu
    Copy the full SHA
    ec60693 View commit details
    Browse the repository at this point in the history

  17. fix: use printing::CompletionCallback again

    @codebytere
    codebytere committed May 24, 2022
    Configuration menu
    Copy the full SHA
    4e8100f View commit details
    Browse the repository at this point in the history

  18. chore: remove patch redundancy

    @codebytere
    codebytere committed May 24, 2022
    Configuration menu
    Copy the full SHA
    53ba1eb View commit details
    Browse the repository at this point in the history

  19. test: fix printToPDF parameter types spec

    @codebytere
    codebytere committed May 24, 2022
    Configuration menu
    Copy the full SHA
    483dcb6 View commit details
    Browse the repository at this point in the history

  20. fix: add back ignore_invalid_page_ranges

    @codebytere
    codebytere committed May 24, 2022
    Configuration menu
    Copy the full SHA
    69101f9 View commit details
    Browse the repository at this point in the history

  21. chore: fix pageRanges param

    @codebytere
    codebytere committed May 24, 2022
    Configuration menu
    Copy the full SHA
    a492a6e View commit details
    Browse the repository at this point in the history

  22. docs: clarify headerTemplate

    @codebytere
    codebytere committed May 24, 2022
    Configuration menu
    Copy the full SHA
    ab7648b View commit details
    Browse the repository at this point in the history

  23. chore: handle rebase changes

    @codebytere
    codebytere committed May 24, 2022
    Configuration menu
    Copy the full SHA
    bf9552d View commit details
    Browse the repository at this point in the history

  24. 3579838: Add failure reason to PrintManagerHost::PrintingFailed() 

    https://chromium-review.googlesource.com/c/chromium/src/+/3579838
    @codebytere
    codebytere committed May 24, 2022
    Configuration menu
    Copy the full SHA
    4c29849 View commit details
    Browse the repository at this point in the history

  25. 3583139: Remove support for ignore_invalid_page_ranges when printing PDF 

    https://chromium-review.googlesource.com/c/chromium/src/+/3583139
    @codebytere
    codebytere committed May 24, 2022
    Configuration menu
    Copy the full SHA
    e64be1b View commit details
    Browse the repository at this point in the history

  26. 3581548: Pass page ranges rather than list of pages to print in Print… 

    …PagesParams

https://chromium-review.googlesource.com/c/chromium/src/+/3581548
    @codebytere
    codebytere committed May 24, 2022
    Configuration menu
    Copy the full SHA
    e1473ce View commit details
    Browse the repository at this point in the history

  27. 3586363: Introduce PrintRenderFrame.PrintWithParams() for batch print… 

    …ing to PDF

https://chromium-review.googlesource.com/c/chromium/src/+/3586363
    @codebytere
    codebytere committed May 24, 2022
    Configuration menu
    Copy the full SHA
    e4ea2d8 View commit details
    Browse the repository at this point in the history

  28. 3583239: Pass max uint value for end of open page range 

    https://chromium-review.googlesource.com/c/chromium/src/+/3583239
    @codebytere
    codebytere committed May 24, 2022
    Configuration menu
    Copy the full SHA
    a88c111 View commit details
    Browse the repository at this point in the history

  29. chore: fixup lint

    @codebytere
    codebytere committed May 24, 2022
    Configuration menu
    Copy the full SHA
    db2be74 View commit details
    Browse the repository at this point in the history

  30. chore: update patches

    @patchup
    patchup[bot] committed May 24, 2022
    Configuration menu
    Copy the full SHA
    b99e2d7 View commit details
    Browse the repository at this point in the history