Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: note safeStorage.isEncryptionAvailable() needs ready event #33724

Merged
merged 1 commit into from Apr 12, 2022
Merged

docs: note safeStorage.isEncryptionAvailable() needs ready event #33724

merged 1 commit into from Apr 12, 2022

Conversation

codebytere
Copy link
Member

Description of Change

Closes #33640.

Checklist

Release Notes

Notes: none.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/18-x-y labels Apr 12, 2022
@electron-cation electron-cation bot added documentation 📓 new-pr 🌱 PR opened in the last 24 hours labels Apr 12, 2022
@codebytere codebytere changed the title docs: note safeStorage.isEncryptionAvailable() needs ready event docs: note safeStorage.isEncryptionAvailable() needs ready event Apr 12, 2022
@VerteDinde VerteDinde merged commit 3057ff0 into main Apr 12, 2022
@VerteDinde VerteDinde deleted the document-needs-ready branch April 12, 2022 19:47
@release-clerk
Copy link

release-clerk bot commented Apr 12, 2022

No Release Notes

This was referenced Apr 12, 2022
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Apr 12, 2022

I have automatically backported this PR to "18-x-y", please check out #33738

@trop
Copy link
Contributor

trop bot commented Apr 12, 2022

I have automatically backported this PR to "19-x-y", please check out #33739

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 13, 2022
bavulapati pushed a commit to bavulapati/electron that referenced this pull request Apr 29, 2022
@codebytere @bavulapati
docs: note safeStorage.isEncryptionAvailable() needs ready event (ele…
113cc62 
…ctron#33724)
@RaisinTen
Copy link
Member

#33913 is not automatically backportable to v15, v16 and v17 because of patch conflicts coming from this change, so I'll try to get this backported.

RaisinTen pushed a commit to RaisinTen/electron that referenced this pull request May 13, 2022
@codebytere @RaisinTen
docs: note safeStorage.isEncryptionAvailable() needs ready event (ele…
6e71b70 
…ctron#33724)
@RaisinTen RaisinTen mentioned this pull request May 13, 2022
Merged
@trop
Copy link
Contributor

trop bot commented May 13, 2022

@RaisinTen has manually backported this PR to "17-x-y", please check out #34218

RaisinTen pushed a commit to RaisinTen/electron that referenced this pull request May 13, 2022
@codebytere @RaisinTen
docs: note safeStorage.isEncryptionAvailable() needs ready event (ele…
9c6436f 
…ctron#33724)
@RaisinTen RaisinTen mentioned this pull request May 13, 2022
Merged
@trop
Copy link
Contributor

trop bot commented May 13, 2022

@RaisinTen has manually backported this PR to "16-x-y", please check out #34219

RaisinTen pushed a commit to RaisinTen/electron that referenced this pull request May 13, 2022
@codebytere @RaisinTen
docs: note safeStorage.isEncryptionAvailable() needs ready event (ele…
4ec3ec4 
…ctron#33724)
@RaisinTen RaisinTen mentioned this pull request May 13, 2022
Merged
@trop
Copy link
Contributor

trop bot commented May 13, 2022

@RaisinTen has manually backported this PR to "15-x-y", please check out #34220

jkleinsc pushed a commit that referenced this pull request May 16, 2022
@RaisinTen @codebytere
docs: note safeStorage.isEncryptionAvailable() needs ready event (#…
dd8c63e 
…34220)

docs: note safeStorage.isEncryptionAvailable() needs ready event (#33724)

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
jkleinsc pushed a commit that referenced this pull request May 16, 2022
@RaisinTen @codebytere
docs: note safeStorage.isEncryptionAvailable() needs ready event (#…
22d81d3 
…34218)

docs: note safeStorage.isEncryptionAvailable() needs ready event (#33724)

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
jkleinsc pushed a commit that referenced this pull request May 16, 2022
@RaisinTen @codebytere
docs: note safeStorage.isEncryptionAvailable() needs ready event (#…
1f15e83 
…34219)

docs: note safeStorage.isEncryptionAvailable() needs ready event (#33724)

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
@commit-lint commit-lint bot mentioned this pull request Jun 14, 2022
Open
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@codebytere @khalwa
docs: note safeStorage.isEncryptionAvailable() needs ready event (ele…
e1f6ace 
…ctron#33724)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VerteDinde VerteDinde VerteDinde approved these changes

@zcbenz zcbenz Awaiting requested review from zcbenz

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

Assignees
No one assigned
Labels
documentation 📓 semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: safeStorage.isEncryptionAvailable() returns false in Windows
3 participants
@codebytere @RaisinTen @VerteDinde