Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add missing GN dep #33758

Merged
merged 1 commit into from Apr 13, 2022
Merged

build: add missing GN dep #33758

merged 1 commit into from Apr 13, 2022

Conversation

codebytere
Copy link
Member

Description of Change

Fixes the following issue seen sporadically in CI:

../..\storage/common/file_system/file_system_util.h(16,10): fatal error: 'third_party/blink/public/mojom/quota/quota_types.mojom.h' file not found
#include "third_party/blink/public/mojom/quota/quota_types.mojom.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
[246 processes, 28041/41753 @ 100.5/s : 278.906s] CXX obj/media/mojo/services/services/gpu_mojo_media_client.obj
[245 processes, 28042/41753 @ 100.5/s : 278.911s] CXX obj/media/mojo/mojom/mojom/content_decryption_module.mojom.obj

Seen in #33704 and previously sent to 18-x-y via #33664

Checklist

Release Notes

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 13, 2022
@codebytere codebytere added semver/patch backwards-compatible bug fixes target/19-x-y labels Apr 13, 2022
@codebytere codebytere changed the title chore: add missing GN dep build: add missing GN dep Apr 13, 2022
@electron-cation electron-cation bot added semver/none and removed new-pr 🌱 PR opened in the last 24 hours labels Apr 13, 2022
@codebytere codebytere removed the semver/patch backwards-compatible bug fixes label Apr 13, 2022
VerteDinde
VerteDinde approved these changes Apr 13, 2022
View reviewed changes
Copy link
Member

@VerteDinde VerteDinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 Thanks for fixing this!

@VerteDinde VerteDinde merged commit bfbba9d into main Apr 13, 2022
@VerteDinde VerteDinde deleted the fix-missing-common-dep branch April 13, 2022 17:55
@release-clerk
Copy link

release-clerk bot commented Apr 13, 2022

No Release Notes

@trop trop bot mentioned this pull request Apr 13, 2022
Merged
@trop
Copy link
Contributor

trop bot commented Apr 13, 2022

I have automatically backported this PR to "19-x-y", please check out #33767

bavulapati pushed a commit to bavulapati/electron that referenced this pull request Apr 29, 2022
@codebytere @bavulapati
chore: add missing GN dep (electron#33758)
250e279
@commit-lint commit-lint bot mentioned this pull request Jun 20, 2022
Open
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@codebytere @khalwa
chore: add missing GN dep (electron#33758)
0225c0c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

@miniak miniak miniak approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

Assignees
No one assigned
Labels
semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@codebytere @nornagon @deepak1556 @miniak @VerteDinde