Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: offscreen rendering crash on input select #34069

Merged
merged 1 commit into from May 5, 2022
Merged

fix: offscreen rendering crash on input select #34069

merged 1 commit into from May 5, 2022

Conversation

codebytere
Copy link
Member

Description of Change

Closes #34047.

Fixes the following crash:

FATAL:frame_sink_video_capturer_impl.cc(304)] Invalid resolutions constraints: 36x0 must not be greater than 36x0; and also within media::limits.

This was happening because we were calling SizeChanged on the video consumer for popup widgets, which would have invalid gfx::Size values for their positions. To fix this, I refactored this to more closely mimic CEF's approach and callpaths, found here.

Tested with https://gist.github.com/gtalusan/c0ad56685aeb3b2c1108fbccf6b451b4.

Checklist

Release Notes

Notes: Fixed an OSR crash happening when input select items were rendered.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/17-x-y labels May 4, 2022
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 4, 2022
nornagon
nornagon approved these changes May 4, 2022
View reviewed changes
Copy link
Member

@nornagon nornagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems legit

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 5, 2022
@jkleinsc jkleinsc merged commit 90eb47f into main May 5, 2022
@jkleinsc jkleinsc deleted the fix-constraint-issue branch May 5, 2022 13:53
@release-clerk
Copy link

release-clerk bot commented May 5, 2022

Release Notes Persisted

Fixed an OSR crash happening when input select items were rendered.

This was referenced May 5, 2022
Merged
Merged
@trop
Copy link
Contributor

trop bot commented May 5, 2022

I have automatically backported this PR to "17-x-y", please check out #34091

@trop trop bot added the in-flight/17-x-y label May 5, 2022
@trop trop bot mentioned this pull request May 5, 2022
Merged
@trop trop bot removed the target/17-x-y label May 5, 2022
@trop
Copy link
Contributor

trop bot commented May 5, 2022

I have automatically backported this PR to "18-x-y", please check out #34092

@trop
Copy link
Contributor

trop bot commented May 5, 2022

I have automatically backported this PR to "19-x-y", please check out #34093

@commit-lint commit-lint bot mentioned this pull request Jul 8, 2022
Open
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@codebytere @khalwa
fix: offscreen rendering crash on input select (electron#34069)
3100041
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@jkleinsc jkleinsc jkleinsc approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@deepak1556 deepak1556 Awaiting requested review from deepak1556

@miniak miniak Awaiting requested review from miniak

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: offscreen rendering doesn't render clicked INPUT SELECT dropdown
4 participants
@codebytere @nornagon @jkleinsc @MarshallOfSound