refactor: use stubs for gdk-pixbuf dependency #34077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzhao271
force-pushed
the
rzhao271/gdk-pixbuf-refactor
branch
from
4f1c058
to
6ae52e8
Compare
deepak1556
reviewed
Jun 16, 2022
deepak1556
reviewed
Jun 16, 2022
5 tasks
5 tasks
deepak1556
approved these changes
Jun 17, 2022
|
Failing tests are unrelated #34575, merging. |
|
Release Notes Persisted
|
|
I have automatically backported this PR to "20-x-y", please check out #34635 |
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
* refactor: use stubs for gdk-pixbuf dependency * Adjust build file * Add includes * Merge gdk_pixbuf stubs into gtk stubs * Split pixbuf sigs into own file again * Add initialization check * Apply PR feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #34060
While adding automatic dependency generation for Debian packages in VS Code (microsoft/vscode#147335), I learned that Electron statically links to libgdk-pixbuf. But, on some versions of Ubuntu, the package is called libgdk-pixbuf-2.0-0, and on other versions, it's called libgdk-pixbuf2.0-0. Therefore, Electron should dynamically look for libgdk-pixbuf rather than statically link to the package, since its name varies depending on the Linux distro version.
This PR is based on #33650, which does something similar for libgtk in Electron.
Also, Chromium has already done something similar for their dependency on libgdk_pixbuf: https://source.chromium.org/chromium/chromium/src/+/3a5f2968e096ebe1faeb156510193e87f07980c9
CC @deepak1556
Checklist
npm testpassesRelease Notes
Notes: On Linux, changed the libgdk-pixbuf dependency to be dynamically linked rather than statically linked.