Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added units to <webview>.print() pageSize option #34088

Merged
merged 1 commit into from May 17, 2022
Merged

docs: added units to <webview>.print() pageSize option #34088

merged 1 commit into from May 17, 2022

Conversation

mkiki01
Copy link
Contributor

@mkiki01 mkiki01 commented May 5, 2022

Description of Change

Closes #33097.

Checklist

Release Notes

Notes: none.

@welcome
Copy link

welcome bot commented May 5, 2022

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added documentation 📓 semver/patch backwards-compatible bug fixes new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels May 5, 2022
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think this would be superseded by #33654 ?

CC @codebytere

@ckerr ckerr requested a review from codebytere May 13, 2022 16:54
@jkleinsc
Copy link
Contributor

@ckerr #33654 modifies ``.printToPDF(options)and this documentation change is for.print(options)`

@jkleinsc jkleinsc merged commit 04b33b3 into electron:main May 17, 2022
@welcome
Copy link

welcome bot commented May 17, 2022

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link

release-clerk bot commented May 17, 2022

No Release Notes

@mkiki01 mkiki01 deleted the docs-webview-tag branch May 18, 2022 12:00
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Print the document WebView The print - > PageSize document is ambiguous
3 participants