Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for HIDDevice.forget() #34210

Merged
merged 7 commits into from May 23, 2022
Merged

feat: add support for HIDDevice.forget() #34210

merged 7 commits into from May 23, 2022

Conversation

jkleinsc
Copy link
Contributor

Description of Change

This PR implements HIDDevice.forget() and also sets up permissioning to allow enabling forget() functionality for Web Serial and Web Bluetooth in future PRs.

Checklist

Release Notes

Notes: Added support for HIDDevice.forget()

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 12, 2022
@jkleinsc jkleinsc requested a review from nornagon May 12, 2022 16:38
ckerr
ckerr approved these changes May 13, 2022
View reviewed changes
spec-main/chromium-spec.ts Outdated Show resolved Hide resolved
@jkleinsc jkleinsc added the semver/minor backwards-compatible functionality label May 16, 2022
@jkleinsc jkleinsc added no-backport and removed new-pr 🌱 PR opened in the last 24 hours labels May 16, 2022
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 16, 2022
samuelmaddock
samuelmaddock suggested changes May 17, 2022
View reviewed changes
Copy link
Member

@samuelmaddock samuelmaddock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

shell/browser/hid/hid_chooser_context.cc Outdated Show resolved Hide resolved
@ckerr
Copy link
Member

ckerr commented May 17, 2022

API LGTM

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 19, 2022
@jkleinsc
Copy link
Contributor Author

Merging as API review has been approved but the bot hasn't updated the github status properly.

@jkleinsc jkleinsc merged commit ba573f5 into main May 23, 2022
@jkleinsc jkleinsc deleted the add-hid-forget branch May 23, 2022 19:13
@release-clerk
Copy link

release-clerk bot commented May 23, 2022

Release Notes Persisted

Added support for HIDDevice.forget()

@commit-lint commit-lint bot mentioned this pull request Jul 27, 2022
Open
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@jkleinsc @samuelmaddock @khalwa
feat: add support for HIDDevice.forget() (electron#34210)
49c0688 
* feat: add support for HIDDevice.forget()

* chore: remove whitespace

* chore: use `SetGetter` to serialize the render_frame_host

Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com>

* fixup chore: use `SetGetter` to serialize the render_frame_host

* fixup after rebase

* fixup for crash on navigator.serial.getPorts()

* fixup for lint

Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@samuelmaddock samuelmaddock samuelmaddock approved these changes

@nornagon nornagon Awaiting requested review from nornagon

Assignees
No one assigned
Labels
api-review/requested 🗳 no-backport semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add support for HIDDevice.forget()
3 participants
@jkleinsc @ckerr @samuelmaddock