test: add setTitlebarOverlay spec
#34221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
commented
May 13, 2022
| @@ -2245,9 +2245,15 @@ describe('BrowserWindow module', () => { | |||
| const overlayEnabled = await w.webContents.executeJavaScript('navigator.windowControlsOverlay.visible'); | |||
| expect(overlayEnabled).to.be.true('overlayEnabled'); | |||
| const overlayRectPreMax = await w.webContents.executeJavaScript('getJSOverlayProperties()'); | |||
| await w.maximize(); | |||
There was a problem hiding this comment.
maximize does not return a promise - we should have been awaiting the event.
codebytere
changed the title
setTitlebarOverlay spec
codebytere
changed the title
setTitlebarOverlay specsetTitlebarOverlay spec
ckerr
approved these changes
May 13, 2022
jkleinsc
approved these changes
May 16, 2022
|
No Release Notes |
|
I have automatically backported this PR to "19-x-y", please check out #34252 |
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
spec: add setTitlebarOverlay spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Follow-up to #34140
Also edits a previously-added test to address some JS issues.
Checklist
npm testpassesRelease Notes
Notes: none