Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add a TRACE call for crash_reporter::Start() #34326

Merged
merged 1 commit into from May 24, 2022
Merged

chore: add a TRACE call for crash_reporter::Start() #34326

merged 1 commit into from May 24, 2022

Commits on May 23, 2022

  1. chore: add a TRACE call for crash_reporter::Start() 

    Initializing the crashReporter takes around 620 milliseconds on Intel
macOS. I have sent a CL to crashpad to partially fix the performance
issue in
https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3641386.
It would be beneficial to log the performance impact of this function in
the traces in case this slows down in the future.

Signed-off-by: Darshan Sen <raisinten@gmail.com>
    @RaisinTen @electron-bot
    RaisinTen authored and electron-bot committed May 23, 2022
    Copy the full SHA
    fae1394 View commit details
    Browse the repository at this point in the history