Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: on macOS show BrowserWindow on maximize if not currently shown #34365

Merged
merged 1 commit into from Jun 6, 2022
Merged

fix: on macOS show BrowserWindow on maximize if not currently shown #34365

merged 1 commit into from Jun 6, 2022

Conversation

dsanders11
Copy link
Member

Backport of #32949.

See that PR for details.

Notes: Fixed behavior of BrowserWindow.maximize on macOS for not shown windows

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 28, 2022
@trop trop bot mentioned this pull request May 28, 2022
Merged
4 tasks
@trop trop bot added 19-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels May 28, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 28, 2022
VerteDinde
VerteDinde approved these changes May 28, 2022
View reviewed changes
Copy link
Member

@VerteDinde VerteDinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙇‍♀️

@zcbenz zcbenz force-pushed the manual-bp/dsanders11/pr/32949/branch/19-x-y branch from 9971e2a to b6a868e Compare June 2, 2022 00:25
@jkleinsc
Copy link
Contributor

jkleinsc commented Jun 6, 2022

@jkleinsc jkleinsc merged commit c0555c1 into electron:19-x-y Jun 6, 2022
@release-clerk
Copy link

release-clerk bot commented Jun 6, 2022

Release Notes Persisted

Fixed behavior of BrowserWindow.maximize on macOS for not shown windows

@dsanders11 dsanders11 deleted the manual-bp/dsanders11/pr/32949/branch/19-x-y branch July 16, 2022 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@zcbenz zcbenz zcbenz approved these changes

@codebytere codebytere codebytere approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

Assignees
No one assigned
Labels
19-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dsanders11 @jkleinsc @zcbenz @codebytere @VerteDinde