fix: missing resource printing DCHECK #34369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
VerteDinde
approved these changes
May 30, 2022
zcbenz
approved these changes
May 30, 2022
|
Release Notes Persisted
|
3 tasks
obra
added a commit
to keyboardio/Chrysalis
that referenced
this pull request
Jun 1, 2022
This is fixed in electron/electron#34369, which should be released in 19.0.3
|
@codebytere I am using "electron": "^19.0.6". printing functionality is working for all other windows. but recently it got crashed on one of my customers. Does it require any backend process. or what step I follow to resolve it. I am unable to resolve that issue. our product is servofeat.com ( @codebytere please help me) System: windows 10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #34358.
Adds missing resource string resultant of CL:3470185
Notes: Fix printing crash when using
webContents.print().