New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: zombie windows when fullscreening and closing #34378
Conversation
82056a2
to
efc897d
Compare
efc897d
to
e8863bb
Compare
e8863bb
to
ddcddd7
Compare
Release Notes Persisted
|
I have automatically backported this PR to "17-x-y", please check out #34390 |
I have automatically backported this PR to "19-x-y", please check out #34391 |
I have automatically backported this PR to "18-x-y", please check out #34392 |
I have automatically backported this PR to "20-x-y", please check out #34393 |
Description of Change
Fixed an issue where zombie windows can be created if
window.close()
is called during a fullscreen transition. We handle this by deferring the close until the transition is complete. This also helpswebView
test flakiness, because we can now close the window and ensure the fullscreen transition is complete.Checklist
npm test
passesRelease Notes
Notes: Fixed an issue where zombie windows can be created if
window.close()
is called during a fullscreen transition.