New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fullscreen windows aren't resizable on macOS #34379
Conversation
When an unresizable window enters fullscreen, it will keep its original size under fullscreen, which looks quite weird. So we made it resizable before entering fullscreen to have it be able to take all the space. |
@zcbenz in that case - let's set the window mask correctly, but update the getter to properly reflect the intended result? Just pushed a commit to illustrate what i mean. |
Yeah this approach should work. |
e9fd621
to
45f2584
Compare
Release Notes Persisted
|
I was unable to backport this PR to "18-x-y" cleanly; |
I was unable to backport this PR to "19-x-y" cleanly; |
I have automatically backported this PR to "20-x-y", please check out #34433 |
@codebytere has manually backported this PR to "19-x-y", please check out #34906 |
@codebytere has manually backported this PR to "18-x-y", please check out #34907 |
Description of Change
On macOS, BrowserWindows cannot be resized when in a fullscreen transition or when actively in fullscreen.
Checklist
npm test
passesRelease Notes
Notes: Fixed an issue where BrowserWindows on macOS were incorrectly marked as resizable.