Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fullscreen windows aren't resizable on macOS #34379

Merged
merged 3 commits into from Jun 3, 2022
Merged

Conversation

codebytere
Copy link
Member

Description of Change

On macOS, BrowserWindows cannot be resized when in a fullscreen transition or when actively in fullscreen.

Checklist

Release Notes

Notes: Fixed an issue where BrowserWindows on macOS were incorrectly marked as resizable.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/18-x-y labels May 30, 2022
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 30, 2022
@zcbenz
Copy link
Member

zcbenz commented May 30, 2022

When an unresizable window enters fullscreen, it will keep its original size under fullscreen, which looks quite weird. So we made it resizable before entering fullscreen to have it be able to take all the space.
#8166

@codebytere
Copy link
Member Author

codebytere commented May 30, 2022

@zcbenz in that case - let's set the window mask correctly, but update the getter to properly reflect the intended result? Just pushed a commit to illustrate what i mean.

@zcbenz
Copy link
Member

zcbenz commented May 30, 2022

let's set the window mask correctly, but update the getter to properly reflect the intended result?

Yeah this approach should work.

@codebytere codebytere force-pushed the fix-resizable branch 3 times, most recently from e9fd621 to 45f2584 Compare May 30, 2022 21:01
shell/browser/native_window_mac.h Outdated Show resolved Hide resolved
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 31, 2022
@codebytere codebytere merged commit 6038e42 into main Jun 3, 2022
@codebytere codebytere deleted the fix-resizable branch June 3, 2022 07:47
@release-clerk
Copy link

release-clerk bot commented Jun 3, 2022

Release Notes Persisted

Fixed an issue where BrowserWindows on macOS were incorrectly marked as resizable.

@trop
Copy link
Contributor

trop bot commented Jun 3, 2022

I was unable to backport this PR to "18-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Jun 3, 2022

I was unable to backport this PR to "19-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Jun 3, 2022

I have automatically backported this PR to "20-x-y", please check out #34433

@trop
Copy link
Contributor

trop bot commented Jul 13, 2022

@codebytere has manually backported this PR to "19-x-y", please check out #34906

@trop
Copy link
Contributor

trop bot commented Jul 13, 2022

@codebytere has manually backported this PR to "18-x-y", please check out #34907

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants