fix: crash in WebFrameMain mojo connection when RenderFrameHost is nullptr #34411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
MarshallOfSound
added
target/18-x-y
semver/patch
samuelmaddock
approved these changes
Jun 1, 2022
VerteDinde
approved these changes
Jun 1, 2022
|
Release Notes Persisted
|
|
I have automatically backported this PR to "18-x-y", please check out #34415 |
|
I have automatically backported this PR to "19-x-y", please check out #34416 |
|
I have automatically backported this PR to "20-x-y", please check out #34417 |
4 tasks
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
…llptr (electron#34411) * fix: crash when RenderFrameHost is nullptr * chore: lint fix Co-authored-by: samuelmaddock <samuel.maddock@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Follow up to #33919. A code path involving speculative RenderFrameHosts being created is resulting in a crash when initially setting up the Mojo connection.
More investigation is still needed to determine what leads to this state where
render_frame_is a nullptr.Checklist
npm testpassesRelease Notes
Notes: Fixed potential crash in WebFrameMain when performing a cross-origin navigation.