docs: add macOS height option info #34451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electron-cation
bot
added
documentation 📓
semver/patch
clavin
approved these changes
Jun 6, 2022
jkleinsc
requested changes
Jun 6, 2022
There was a problem hiding this comment.
LGTM, but https://github.com/electron/electron/blob/main/docs/api/browser-window.md should also be changed
It looks like it was already listed as:
so only the tutorial doc needs to be updated |
zcbenz
approved these changes
Jun 9, 2022
jkleinsc
approved these changes
Jun 9, 2022
|
@mlaurencin I was thinking https://github.com/electron/electron/blob/main/docs/api/browser-window.md#winsettitlebaroverlayoptions-windows needed to be updated but I see that is Windows only functionality. |
|
Release Notes Persisted
|
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR modifies the documentation for the WCO height option added by #34278 to include macOS functionality.
Checklist
npm testpassesRelease Notes
Notes: None