fix: focus window when showing via maximize on macOS #34465
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool! |
|
@bpasero, still in draft mode, looks like there's a test failure on Windows I need to look into to better understand. 🙂 But will hopefully flip it to ready soon. |
|
No worries, I have just pushed a change for VSCode insiders to always call |
dsanders11
force-pushed
the
macos-browserwindow-maximize-fix
branch
2 times, most recently
from
f8a9465
to
8bb18bd
Compare
dsanders11
force-pushed
the
macos-browserwindow-maximize-fix
branch
from
5aeaca7
to
1151652
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Other platforms focus an unshown window when maximizing it causes it to become visible, and seem to have for a long time. This PR updates macOS to match the other platform behavior and corrects the documentation. See comments on #32949 for more detailed discussion.
Should the docs change be bumped out to a different PR? It gets a bit hidden in here, which isn't ideal.
Checklist
npm testpassesRelease Notes
Notes: Fixed focus on macOS when calling BrowserWindow.maximize for not shown windows.