fix: all files selection logic on linux #34496
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #34492.
Fixes an issue where passing
{ name: 'All Files', extensions: ['*'] }
in thefilters
param of open or save dialogs on linux would disallow choosing files without an extension. This was happening because we were modifying all filters passed in to prefix them with*.
:electron/shell/browser/ui/file_dialog_gtk.cc
Line 39 in 99b86a0
meaning that the All Files extension would turn into
*.*
. This meaningfully changed behavior, because*
in isolation allows a user to choose any file but*.*
allows a user to choose any file with any extension but the extension must exist. This corrects that behavior.Checklist
npm test
passesRelease Notes
Notes: Fixes an issue where passing
{ name: 'All Files', extensions: ['*'] }
in thefilters
param of open or save dialogs on Linux would disallow choosing files without an extension.