New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: window button visibility fullscreen interaction #34530
Conversation
073ebe7
to
10b3345
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The BrowserWindow.setWindowButtonVisibility()
tests are failing.
10b3345
to
c0da80a
Compare
Release Notes Persisted
|
I have automatically backported this PR to "18-x-y", please check out #34673 |
I have automatically backported this PR to "19-x-y", please check out #34674 |
I have automatically backported this PR to "20-x-y", please check out #34675 |
Description of Change
Closes #34507.
Fixes an issue where calling
w.setWindowButtonVisibility(true)
immediately after exiting fullscreen fails to show window buttons. This was happening owing to a race condition due to the asynchronous nature ofwindow.setFullscreen
- our logic hides and then restores custom window buttons to prevent them jumping around. However, ifw.setWindowButtonVisibility(true)
is called afterwindow.setFullscreen
and the transition has not yet completed, then the window button won't get redrawn and this the buttons won't show up again. Fix this by ensuring that the buttons get redrawn appropriately inw.setWindowButtonVisibility
.Checklist
npm test
passesRelease Notes
Notes: Fixes an issue where calling
w.setWindowButtonVisibility(true)
immediately after exiting fullscreen fails to show window buttons.