chore: remove undocumented page-title-set webview event #34533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miniak
force-pushed
the
miniak/remove-page-title-set-event
branch
from
e32bcc2
to
9bb6419
Compare
miniak
changed the title
nornagon
approved these changes
Jun 13, 2022
There was a problem hiding this comment.
It was the old name for the event back in 2015, but I think it's safe to remove now.
commit e5974e44ed5584db59eac5318b5d0b2dbd1dba7e
Author: Cheng Zhao <zcbenz@gmail.com>
Date: Tue Dec 1 18:50:56 2015 +0800
Deprecate the page-title-set event
We have two names for the same event, page-title-updated wins.
diff --git a/docs/api/web-view-tag.md b/docs/api/web-view-tag.md
index 47a3050a04..56909a52e3 100644
--- a/docs/api/web-view-tag.md
+++ b/docs/api/web-view-tag.md
@@ -452,15 +452,15 @@ Fired when a redirect was received while requesting a resource.
Fired when document in the given frame is loaded.
-### Event: 'page-title-set'
+### Event: 'page-title-updated'
|
API LGTM |
1 similar comment
|
API LGTM |
miniak
force-pushed
the
miniak/remove-page-title-set-event
branch
from
9bb6419
to
8d44427
Compare
electron-cation
bot
added
api-review/approved ✅
and removed
new-pr 🌱
|
Release Notes Persisted
|
schetle
pushed a commit
to schetle/electron
that referenced
this pull request
Nov 3, 2022
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This event has been undocumented for ages.
Checklist
npm testpassesRelease Notes
Notes: The undocumented
page-title-setwebview event has been removed.