feat: add immersive dark mode on windows #34550
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
* feat: add immersive dark mode * fix syntax and add header * add me * Update fuses.json5 * fix: redraw title bar on dark mode change * chore: SetWindowTheme doesn't seem to be needed * chore: separate out Win 10 dark mode implementation * final touches * final touches * chore: limit Win 10 to >= 20H1 and drop fuse * fix types * fix lint Co-authored-by: Micha Hanselmann <micha.hanselmann@gmail.com> Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
4 tasks
trop
bot
added
19-x-y
backport
MarshallOfSound
requested changes
Jun 14, 2022
miniak
approved these changes
Jun 15, 2022
|
Discussed in Releases WG meeting on 6/23/22 - would like to see this tested in Electron 20 stable before backporting to other release branches. |
trop
bot
deleted the
trop/19-x-y-bp-feat-add-immersive-dark-mode-on-windows-1655224067603
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #33624
See that PR for details.
Notes: Added immersive dark mode on Windows.