chore: fix BrowserView painting when origin updated #34581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcbenz
approved these changes
Jun 16, 2022
codebytere
force-pushed
the
fix-paint-updating
branch
from
1153cef
to
ff02807
Compare
|
Release Notes Persisted
|
|
I have automatically backported this PR to "18-x-y", please check out #34641 |
This was referenced Jun 20, 2022
|
I have automatically backported this PR to "19-x-y", please check out #34642 |
|
I have automatically backported this PR to "20-x-y", please check out #34643 |
3 tasks
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
chore: fix View painting when origin updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #34580.
Fixes an issue where changes to bounds that changed the origin and not the width or height did not consistently result in repaints.
Tested with https://gist.github.com/de7bb5f18826338729e03441da70e102.
Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where BrowserViews didn't always visually update after call to
setBounds