build: build & release libcxx objects on darwin #34586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
approved these changes
Jun 16, 2022
zcbenz
approved these changes
Jun 20, 2022
|
Release Notes Persisted
|
VerteDinde
added a commit
that referenced
this pull request
Jun 21, 2022
This reverts commit 2bbbc66.
VerteDinde
added a commit
that referenced
this pull request
Jun 21, 2022
VerteDinde
added a commit
that referenced
this pull request
Jun 21, 2022
* build: build & release libcxx objects on darwin * Fix merge error Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
VerteDinde
added a commit
that referenced
this pull request
Jun 23, 2022
* build: build & release libcxx objects on darwin * Fix merge error Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
schetle
pushed a commit
to schetle/electron
that referenced
this pull request
Nov 3, 2022
* build: build & release libcxx objects on darwin * Fix merge error Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
schetle
pushed a commit
to schetle/electron
that referenced
this pull request
Nov 3, 2022
…ron#34586)" (electron#34680) Revert "build: build & release libcxx objects on darwin (electron#34586)" This reverts commit 2bbbc66.
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
* build: build & release libcxx objects on darwin * Fix merge error Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
…ron#34586)" (electron#34680) Revert "build: build & release libcxx objects on darwin (electron#34586)" This reverts commit 2bbbc66.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
We previously added libcxx + libcxxabi headers and libcxx object files to release artifacts. The headers are platform agnostic, but the object files are currently exported per platform, and are Linux only. This PR adds additional build and upload steps for exporting those object files on MacOS.
(Windows will require building libc++ as a static library rather than source set before similar support can be added)
Checklist
npm testpassesRelease Notes
Notes: Changed release uploads to now upload libcxx objects for MacOS x64 and arm64.