fix: overzealous media key listening on Windows #34594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VerteDinde
approved these changes
Jun 16, 2022
zcbenz
approved these changes
Jun 20, 2022
|
Release Notes Persisted
|
|
I was unable to backport this PR to "18-x-y" cleanly; |
This was referenced Jun 20, 2022
|
I have automatically backported this PR to "19-x-y", please check out #34646 |
|
I have automatically backported this PR to "20-x-y", please check out #34647 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #32385.
Fixes an issue where media keys would be sent to Electron on Windows no matter which window was in focus. This is fixed by only adding a
ui::MediaKeysListeneron either systems that don't supportSystemMediaControls(e.g. Windows 7/8) or macOS, since that's necessary to ensure proper functionality ofglobalShortcutson macOS.Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where media keys would be sent to Electron on Windows no matter which window was in focus.