fix: set macOS crypto keychain name earlier #34683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarshallOfSound
added
target/18-x-y
semver/patch
|
I'm sure it goes without saying, but one point of caution with this change is that anyone who depended on the previous behavior (however erroneous) will now get errors following this patch. |
codebytere
approved these changes
Jun 22, 2022
|
We should probably also add the test mentioned in #34614 (comment), to make sure that this never regresses in the future. |
VerteDinde
approved these changes
Jun 22, 2022
jkleinsc
previously requested changes
Jun 23, 2022
MarshallOfSound
force-pushed
the
init-mac-keychain-early
branch
from
aceb554
to
905b970
Compare
|
Release Notes Persisted
|
MarshallOfSound
added
the
target/21-x-y
|
I was unable to backport this PR to "18-x-y" cleanly; |
This was referenced Sep 23, 2022
|
I have automatically backported this PR to "19-x-y", please check out #35795 |
|
I have automatically backported this PR to "20-x-y", please check out #35796 |
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
* fix: set macOS crypto keychain name earlier * spec: ensure arm64 mac tests are cleaned up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34614
Notes: Usage of
safeStoragenow consistently uses the correct service name on macOS regardless of timing with browser window construction