New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: <datalist>
bounds vertical cutoff
#34759
Conversation
<datalist>
bounds vertical cutoff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for the branch name 😆
Unrelated Node.js failure on Linux. |
Release Notes Persisted
|
I have automatically backported this PR to "19-x-y", please check out #34785 |
I have automatically backported this PR to "20-x-y", please check out #34786 |
Description of Change
Closes #34750.
Refs CL:3560843
Fixes an issue where DataList bounds had part of the item text cut off vertically. This happened in #33556 when we switched from the mult-parameter form of
gfx::Insets
, since the horizontal and vertical parameters switched and we didn't catch it.Tested with https://gist.github.com/1525a4d39d33bc46eb033af6ebcf51c1.
Checklist
npm test
passesRelease Notes
Notes: Fixed an issue where DataList bounds had part of the item text cut off vertically.