fix: alwaysOnTop browser window option for X11 Linux #34766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
approved these changes
Jun 28, 2022
codebytere
added
semver/patch
|
Node test failures on linux are flakes; merging. |
|
Release Notes Persisted
|
This was referenced Jul 13, 2022
|
I have automatically backported this PR to "18-x-y", please check out #34911 |
|
I have automatically backported this PR to "19-x-y", please check out #34912 |
|
I have automatically backported this PR to "20-x-y", please check out #34913 |
schetle
pushed a commit
to schetle/electron
that referenced
this pull request
Nov 3, 2022
fix: alwaysontop browser window option for x11
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
fix: alwaysontop browser window option for x11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #32889
On X11 when alwaysOnTop was set as a browser window preference, it got applied to the window before showing it. While that set the z-index of the window in X11, it didn't take effect, it just behaved as a window without alwaysOnTop.
This was working correctly prior to Electron 16, but not ever since. No idea why it broke, didn't find any trace for it.
Checklist
npm testpassesRelease Notes
Notes: Fix alwaysOnTop BrowserWindow option for X11 Linux