fix: re-enable HKDF crypto functionality #34767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak1556
reviewed
Jun 29, 2022
| ['sha256', 'secret', 'salt', 'info', 10], | ||
| ['sha512', 'secret', 'salt', '', 15], | ||
| ]; | ||
| -if (!common.hasOpenSSL3) |
There was a problem hiding this comment.
Can we expose a property common.openSSLisBoringSSL based on the build time constant OPENSSL_IS_BORINGSSL that is already available in upstream Node.js. It could simplify the patch in a upstream friendly way.
There was a problem hiding this comment.
@deepak1556 it's stalled but i actually started that ages ago: nodejs/node#38928
There was a problem hiding this comment.
Oh cool, btw agree with the concern in nodejs/node#38928 (review), shouldn't the change be
#ifdef OPENSSL_IS_BORINGSSL
#define IS_BORINGSSL 1
NODE_DEFINE_CONSTANT(target, IS_BORINGSSL);
#undef IS_BORINGSSL
#endif
deepak1556
approved these changes
Jun 29, 2022
|
Release Notes Persisted
|
schetle
pushed a commit
to schetle/electron
that referenced
this pull request
Nov 3, 2022
* fix: re-enable HKDF crypto functionality * chore: update patches Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
* fix: re-enable HKDF crypto functionality * chore: update patches Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #31634.
Enables HKDF support in embedded Node.js as a result of https://boringssl-review.googlesource.com/c/boringssl/+/52829.
Checklist
npm testpassesRelease Notes
Notes: Enable missing HKDF support in Node.js
crypto.