Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Windows caption buttons to match Win11 style #34790

Merged
merged 2 commits into from Jul 12, 2022

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Jun 29, 2022

Description of Change

Refs CL:3674580

This PR updates WCO restore and maximize buttons to match Windows 11 design. It also refactors out the functionality into its own file, as the above CL does, to make it more maintainable an extensible

Checklist

Release Notes

Notes: Updated Windows Control Overlay buttons to look and feel more native on Windows 11.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/20-x-y labels Jun 29, 2022
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 29, 2022
@codebytere codebytere force-pushed the win-icon-painter branch 2 times, most recently from 8def0c3 to d782824 Compare June 29, 2022 16:12
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 30, 2022
@codebytere
Copy link
Member Author

@clavin issues should be resolved!

@codebytere codebytere requested a review from zcbenz July 11, 2022 10:02
@codebytere codebytere merged commit 95019f0 into main Jul 12, 2022
@codebytere codebytere deleted the win-icon-painter branch July 12, 2022 07:13
@release-clerk
Copy link

release-clerk bot commented Jul 12, 2022

Release Notes Persisted

Updated Windows Control Overlay buttons to look and feel more native on Windows 11.

@trop
Copy link
Contributor

trop bot commented Jul 12, 2022

I have automatically backported this PR to "20-x-y", please check out #34888

@trop
Copy link
Contributor

trop bot commented Aug 11, 2022

@rzhao271 has manually backported this PR to "19-x-y", please check out #35314

rzhao271 pushed a commit to rzhao271/electron that referenced this pull request Aug 12, 2022
devinfoley pushed a commit to devinfoley/electron that referenced this pull request Aug 16, 2022
fix: update Windows caption buttons to match Win11 style (electron#34790)

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
schetle pushed a commit to schetle/electron that referenced this pull request Nov 3, 2022
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants