New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update Windows caption buttons to match Win11 style #34790
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
force-pushed
the
win-icon-painter
branch
2 times, most recently
from
June 29, 2022 16:12
8def0c3
to
d782824
Compare
codebytere
force-pushed
the
win-icon-painter
branch
from
June 29, 2022 17:35
d782824
to
3f42390
Compare
mlaurencin
approved these changes
Jun 29, 2022
clavin
requested changes
Jun 29, 2022
codebytere
force-pushed
the
win-icon-painter
branch
from
July 7, 2022 07:27
99aa161
to
3e5935d
Compare
@clavin issues should be resolved! |
clavin
approved these changes
Jul 11, 2022
Release Notes Persisted
|
I have automatically backported this PR to "20-x-y", please check out #34888 |
3 tasks
5 tasks
rzhao271
pushed a commit
to rzhao271/electron
that referenced
this pull request
Aug 12, 2022
devinfoley
pushed a commit
to devinfoley/electron
that referenced
this pull request
Aug 16, 2022
fix: update Windows caption buttons to match Win11 style (electron#34790) Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
schetle
pushed a commit
to schetle/electron
that referenced
this pull request
Nov 3, 2022
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Refs CL:3674580
This PR updates WCO restore and maximize buttons to match Windows 11 design. It also refactors out the functionality into its own file, as the above CL does, to make it more maintainable an extensible
Checklist
npm test
passesRelease Notes
Notes: Updated Windows Control Overlay buttons to look and feel more native on Windows 11.