New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: safer check for WCO button updates #34833
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
One extra thought: is there anything we can do about renaming these methods to make it harder to mess this up in the future?
Release Notes Persisted
|
I have automatically backported this PR to "18-x-y", please check out #34873 |
I have automatically backported this PR to "19-x-y", please check out #34874 |
I have automatically backported this PR to "20-x-y", please check out #34875 |
/trop run backport-to 17-x-y |
The backport process for this PR has been manually initiated - sending your PR to |
I have automatically backported this PR to "17-x-y", please check out #35031 |
Description of Change
Refs #34677.
Fixes a potential crash when changing window settings after initializing WCO with an invalid
titleBarStyle
. We need both to ensure that the overlay has been set and also that thetitleBarStyle
is valid for the platform.Checklist
npm test
passesRelease Notes
Notes: Fixed a potential crash when changing window settings after initializing WCO with an invalid
titleBarStyle
.