fix: setRepresentedFilename with non-default titlebarStyle
#34834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
requested review from
jkleinsc,
zcbenz,
VerteDinde and
MarshallOfSound
codebytere
changed the title
setRepresentedFilename with non-default titlebarStyle
VerteDinde
approved these changes
Jul 7, 2022
MarshallOfSound
approved these changes
Jul 8, 2022
|
Release Notes Persisted
|
This was referenced Jul 8, 2022
|
I have automatically backported this PR to "18-x-y", please check out #34847 |
|
I have automatically backported this PR to "19-x-y", please check out #34848 |
|
I have automatically backported this PR to "20-x-y", please check out #34849 |
schetle
pushed a commit
to schetle/electron
that referenced
this pull request
Nov 3, 2022
…ron#34834) fix: setRepresentedFilename with non-default titlebarStyle
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
…ron#34834) fix: setRepresentedFilename with non-default titlebarStyle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #34822.
Fixes an issue where calling
BrowserWindow.setRepresentedFilenameon macOS withtitlebarStyle: 'hiddenInset'ortitlebarStyle: 'hidden'inadvertently moves the traffic light location. Fix this by ensuring the traffic lights are redrawn according to the currenttitleBarStylewhenrepresentedFilenamevalue is changed.Tested with https://gist.github.com/9ad043673ca425c92bbb4e1f951c455c
Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where calling
BrowserWindow.setRepresentedFilenameon macOS withtitlebarStyle: 'hiddenInset'ortitlebarStyle: 'hidden'inadvertently moves the traffic light location.