Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure v8 pointer compression + sandbox is enabled on 64bit native modules #34851

Merged
merged 5 commits into from Jul 8, 2022
Merged

fix: ensure v8 pointer compression + sandbox is enabled on 64bit native modules #34851

merged 5 commits into from Jul 8, 2022

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jul 8, 2022

Backport of #34844

See that PR for details.

Notes: Fixed spontaneous crashing in native modules that depended on nan

@trop trop bot requested review from a team as code owners July 8, 2022 08:06
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 8, 2022
@trop trop bot requested a review from MarshallOfSound July 8, 2022 08:06
@trop trop bot mentioned this pull request Jul 8, 2022
Merged
@trop trop bot added 20-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jul 8, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 8, 2022
@MarshallOfSound
Copy link
Member

Currently this PR sets v8_enable_sandbox to 0 no matter what, that is because the v8 sandbox is still disabled in the 20-x-y branch. When it is enabled that flag should be flipped to 1 in this patch.

@VerteDinde
Copy link
Member

WOA is green, but GitHub hasn't updated status - merging as others are green

@VerteDinde VerteDinde merged commit c10eece into 20-x-y Jul 8, 2022
@VerteDinde VerteDinde deleted the trop/20-x-y-bp-fix-ensure-v8-pointer-compression-sandbox-is-enabled-on-64bit-native-modules-1657267590845 branch July 8, 2022 11:51
@release-clerk
Copy link

release-clerk bot commented Jul 8, 2022

Release Notes Persisted

Fixed spontaneous crashing in native modules that depended on nan

@VerteDinde VerteDinde mentioned this pull request Jul 11, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VerteDinde VerteDinde VerteDinde approved these changes

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

Assignees
No one assigned
Labels
20-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MarshallOfSound @VerteDinde