Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: potential hang on print settings failure #34892

Merged
merged 1 commit into from Jul 19, 2022
Merged

fix: potential hang on print settings failure #34892

merged 1 commit into from Jul 19, 2022

Conversation

codebytere
Copy link
Member

Description of Change

Fixes a potential printing hang. Before this fix, if the printing_context_ failed to resolve the default settings, GetSettingsDone would never be called. This corrects the issue.

Checklist

Release Notes

Notes: Fixed a potential printing hang.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/18-x-y labels Jul 12, 2022
@codebytere codebytere requested review from a team as code owners July 12, 2022 11:57
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 12, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 13, 2022
@codebytere codebytere force-pushed the fix-settings-failure-callback branch from 836ae1e to a087c12 Compare July 14, 2022 08:48
@codebytere
Copy link
Member Author

Known unrelated failure.

@codebytere codebytere merged commit 57b02e1 into main Jul 19, 2022
@codebytere codebytere deleted the fix-settings-failure-callback branch July 19, 2022 09:45
@release-clerk
Copy link

release-clerk bot commented Jul 19, 2022

Release Notes Persisted

Fixed a potential printing hang.

@trop
Copy link
Contributor

trop bot commented Jul 19, 2022

I was unable to backport this PR to "18-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Jul 19, 2022

I was unable to backport this PR to "19-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/19-x-y label Jul 19, 2022
@trop trop bot mentioned this pull request Jul 19, 2022
Merged
@trop
Copy link
Contributor

trop bot commented Jul 19, 2022

I have automatically backported this PR to "20-x-y", please check out #34968

@commit-lint commit-lint bot mentioned this pull request Sep 21, 2022
Open
schetle pushed a commit to schetle/electron that referenced this pull request Nov 3, 2022
@codebytere @schetle
fix: potential hang on print settings failure (electron#34892)
073bc53
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@codebytere @khalwa
fix: potential hang on print settings failure (electron#34892)
4bf055b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@zcbenz zcbenz Awaiting requested review from zcbenz

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codebytere @deepak1556 @miniak