fix: crash on BrowserWindow.setEnabled()
#34904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VerteDinde
approved these changes
Jul 13, 2022
codebytere
commented
Jul 13, 2022
| @@ -484,7 +484,8 @@ void ViewDidMoveToSuperview(NSView* self, SEL _cmd) { | |||
| // [window_ performClose:nil], the window won't close properly | |||
| // even after the user has ended the sheet. | |||
| // Ensure it's closed before calling [window_ performClose:nil]. | |||
| SetEnabled(true); | |||
| if ([window_ attachedSheet]) | |||
There was a problem hiding this comment.
this is changed to make more explicit exactly what is happening.
codebytere
force-pushed
the
fix-setenabled-crash
branch
from
08ebc2b
to
b58f6eb
Compare
|
Release Notes Persisted
|
This was referenced Jul 19, 2022
|
I have automatically backported this PR to "19-x-y", please check out #34971 |
|
I have automatically backported this PR to "20-x-y", please check out #34972 |
|
I have automatically backported this PR to "18-x-y", please check out #34973 |
schetle
pushed a commit
to schetle/electron
that referenced
this pull request
Nov 3, 2022
fix: crash on BrowserWindow.setEnabled()
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
fix: crash on BrowserWindow.setEnabled()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #34707.
Fixes an issue where calling
BrowserWindow.setEnabled(false)would crash. This was happening because we were attempting to create a sheet modal on the window with itself. Fix this by instead creating a dummy sheet window to disable interaction with the main window.Checklist
npm testpassesRelease Notes
Notes: Fixed a crash when calling
BrowserWindow.setEnabled().