fix: html fullscreen transitions stacking #34909
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
trop
bot
added
18-x-y
backport
RaisinTen
reviewed
Jul 14, 2022
| const width = await w.webContents.executeJavaScript( | ||
| "document.querySelector('iframe').offsetWidth" | ||
| ); | ||
| expect(width).to.equal(0); |
There was a problem hiding this comment.
This assertion is failing on macOS builds:
not ok 1114 iframe using HTML fullscreen API while window is OS-fullscreened can fullscreen from out-of-process iframes (macOS)
AssertionError: expected 1024 to equal 0
at Context.<anonymous> (electron/spec-main/chromium-spec.ts:1701:22)| // TODO(jkleinsc) fix this flaky test on WOA | ||
| ifit(process.platform !== 'win32' || process.arch !== 'arm64')('can fullscreen from in-process iframes', async () => { | ||
| if (process.platform === 'darwin') await emittedOnce(w, 'enter-full-screen'); |
There was a problem hiding this comment.
I think this event is not emitted and so, this test times out on macOS:
not ok 1115 iframe using HTML fullscreen API while window is OS-fullscreened can fullscreen from in-process iframes
Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/distiller/project/src/electron/spec-main/chromium-spec.ts)
at listOnTimeout (node:internal/timers:557:17)
at processTimers (node:internal/timers:500:7)
|
Gonna leave this in 19 and 20. Forgot this hinged on an upstream change not in 18. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #32905.
See that PR for details.
Notes: Fixes an issue with fullscreen transitions when HTML fullscreen is requested.