Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure that v8 sandbox isnt enabled for arm #34914

Merged
merged 1 commit into from Jul 14, 2022
Merged

fix: ensure that v8 sandbox isnt enabled for arm #34914

merged 1 commit into from Jul 14, 2022

Conversation

MarshallOfSound
Copy link
Member

Notes: Fixes native module compilation issues on arm

@MarshallOfSound MarshallOfSound requested review from a team as code owners July 13, 2022 20:11
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 13, 2022
@MarshallOfSound MarshallOfSound added semver/patch backwards-compatible bug fixes target/20-x-y fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases labels Jul 13, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 13, 2022
@codebytere codebytere merged commit 9a5d759 into main Jul 14, 2022
@codebytere codebytere deleted the fix-arm-native-modules branch July 14, 2022 08:46
@release-clerk
Copy link

release-clerk bot commented Jul 14, 2022

Release Notes Persisted

Fixes native module compilation issues on arm

@trop
Copy link
Contributor

trop bot commented Jul 14, 2022

I was unable to backport this PR to "20-x-y" cleanly;
you will need to perform this backport manually.

VerteDinde pushed a commit that referenced this pull request Jul 29, 2022
@MarshallOfSound @VerteDinde
fix: ensure that v8 sandbox isnt enabled for arm (#34914)
29ecd69
@VerteDinde VerteDinde mentioned this pull request Jul 29, 2022
Merged
@trop
Copy link
Contributor

trop bot commented Jul 29, 2022

@VerteDinde has manually backported this PR to "20-x-y", please check out #35137

jkleinsc pushed a commit that referenced this pull request Jul 29, 2022
@VerteDinde @MarshallOfSound
fix: ensure that v8 sandbox isnt enabled for arm (#35137)
76450af 
fix: ensure that v8 sandbox isnt enabled for arm (#34914)

Co-authored-by: Samuel Attard <sam@electronjs.org>
@commit-lint commit-lint bot mentioned this pull request Sep 19, 2022
Open
schetle pushed a commit to schetle/electron that referenced this pull request Nov 3, 2022
@MarshallOfSound @schetle
fix: ensure that v8 sandbox isnt enabled for arm (electron#34914)
677f78c
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@MarshallOfSound @khalwa
fix: ensure that v8 sandbox isnt enabled for arm (electron#34914)
c76e749
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@codebytere codebytere codebytere approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

Assignees
No one assigned
Labels
fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MarshallOfSound @nornagon @codebytere @VerteDinde