chore: cherry-pick 5e227bebf193 from v8 #34931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VerteDinde
added
backport-check-skip
electron-cation
bot
added
new-pr 🌱
MarshallOfSound
approved these changes
Jul 15, 2022
|
The publish-linux job actually passed past the previous failure; it's failing on upload here, which is unrelated to this change: https://app.circleci.com/pipelines/github/electron/electron/55651/workflows/0b3f9d5f-d13d-482a-a2e8-878ead6833e9/jobs/1268880 |
|
Release Notes Persisted
|
schetle
pushed a commit
to schetle/electron
that referenced
this pull request
Nov 3, 2022
* chore: cherry-pick 5e227bebf193 from v8 * chore: update patches Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
* chore: cherry-pick 5e227bebf193 from v8 * chore: update patches Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This should fix a currently nightly blocker on main with linux arm64 publishing. This fix should be present in the next Chrome roll, and we can remove the patch when that's merged.
[arm64] Fix undefined symbol linker error
Assembler::CheckBuffer() was defined inline in a header file but without
inline linkage, causing an undefined symbol link error on arm64 macOS.
Fixes: nodejs/node-v8#233
Bug: v8:13055
Change-Id: Ifb638705e95de72b2e8d472e7092e88d77cf8ba8
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3749583
Auto-Submit: Ben Noordhuis info@bnoordhuis.nl
Reviewed-by: Leszek Swirski leszeks@chromium.org
Reviewed-by: Jakob Kummerow jkummerow@chromium.org
Commit-Queue: Leszek Swirski leszeks@chromium.org
Cr-Commit-Position: refs/heads/main@{#81749}
Notes: Backported fix for v8:13055.