Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken wayland window decorations due to botched chromium update #34945

Conversation

msizanoen1
Copy link
Contributor

@msizanoen1 msizanoen1 commented Jul 18, 2022

Description of Change

The GetTitlebarBounds().height() expression is obviously intended to be placed in the top parameter, which used to be the second one before upstream removed multi-parameter gfx::Rect::Inset, but it's the first parameter for gfx::Insets::TLBR, which was intended to replace the removed Inset function. However, whoever updated Chromium kept the parameter ordering unchanged, causing the title bar height to be passed to the left parameter, causing the window title bar to be unclickable.

Fixes partially #34820

Checklist

Release Notes

Notes: Fix mangled Wayland client-side decorations

The `GetTitlebarBounds().height()` is obviously intended to be placed in
the `top` parameter, which used to be the second one before upstream
removed multi-parameter `gfx::Rect::Inset`, but it's the first parameter
for `gfx::Insets::TLBR`, which was intended to replace the removed
`Inset` function. However, whoever updated Chromium kept the parameter
unchanged, causing the title bar height to be passed to the `left`
parameter, causing the window title bar to be unclickable.
@welcome
Copy link

welcome bot commented Jul 18, 2022

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 18, 2022
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@deepak1556 deepak1556 added semver/patch backwards-compatible bug fixes target/19-x-y labels Jul 18, 2022
Copy link
Contributor

@refi64 refi64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this!

@msizanoen1 msizanoen1 mentioned this pull request Jul 18, 2022
2 tasks
@ckerr
Copy link
Member

ckerr commented Jul 18, 2022

This is a nice fix and is approved, but I'm going to close it since @msizanoen1 has marked it as superseded by #34955 and the PR there does include this fix. So let's continue discussion over in that PR

@ckerr ckerr closed this Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-pr 🌱 PR opened in the last 24 hours semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants