fix: broken wayland window decorations due to botched chromium update #34945
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The
GetTitlebarBounds().height()
expression is obviously intended to be placed in thetop
parameter, which used to be the second one before upstream removed multi-parametergfx::Rect::Inset
, but it's the first parameter forgfx::Insets::TLBR
, which was intended to replace the removedInset
function. However, whoever updated Chromium kept the parameter ordering unchanged, causing the title bar height to be passed to theleft
parameter, causing the window title bar to be unclickable.Fixes partially #34820
Checklist
npm test
passesRelease Notes
Notes: Fix mangled Wayland client-side decorations