New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: empty result of webContents.getUserAgent()
#35069
Conversation
This seems to be affecting the latest v19 patch release too, so a backport may be needed |
@codebytere why not 17-x-y? The previous fix, which regressed this was backported to 17-x-y |
@miniak 17 is security fixes only |
@codebytere theoretically yes, but that's not what's been done if you check the commit history |
Release Notes Persisted
|
I have automatically backported this PR to "18-x-y", please check out #35130 |
I have automatically backported this PR to "20-x-y", please check out #35131 |
I have automatically backported this PR to "19-x-y", please check out #35132 |
/trop run backport-to 17-x-y |
The backport process for this PR has been manually initiated - sending your PR to |
I have automatically backported this PR to "17-x-y", please check out #35151 |
ฉันไม่มีความรู้ความสามารถในการใช้งาน ฉันอยากขอความร่วมมือให้ทุกฝ่ายช่วยประสานงาน ส่งข้อมูลส่วนตัวที่เกี่ยวกับเนื้อหาในการเปิดเผยข้อมูลส่วนตัว และช่วยประชาสัมพันธ์ต่อสื่อสาธารณะที่เหมาะสม และให้เงินทุนสนับสนุนก่อนที่ฉันจะเข้าร่มงานและฝึกทักษะการเนียนรู้ในอนาคตข้างหน้า |
fix: empty result of webContents.getUserAgent()
fix: empty result of webContents.getUserAgent()
Description of Change
Closes #35046.
Refs #34481 - this change made it such that we were no longer initializing the user agent and so it would always be empty when calling
webContents.getUserAgent()
unless it had been previously set bywebContents.setUserAgent(agent)
. This fixes that, and incidentally removes the need to have a separateGetUserAgentOverride
.Confirmed not to regress #30201
Checklist
npm test
passesRelease Notes
Notes: Fixed
webContents.getUserAgent()
incorrectly returning an empty string unless previously set.