New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove skip-taskbar feature on Linux. #35123
Conversation
Marked as unsupported in e19, now removed in e20. See #33226 for more information
Should we also remove support of https://github.com/electron/electron/blob/main/docs/api/browser-window.md#winsetskiptaskbarskip for linux ? Looks like #33226 did not cover this. |
@ckerr we should remove this note about linux here too: electron/docs/api/browser-window.md Lines 180 to 182 in 21ef850
|
c87820d
to
f75a353
Compare
Release Notes Persisted
|
I have automatically backported this PR to "20-x-y", please check out #35156 |
@codebytere the comment #35123 (comment) still holds true, https://github.com/electron/electron/blob/main/shell/browser/native_window_views.cc#L1043-L1047 supports the feature via |
Description of Change
This doesn't work in Wayland and won't be fixed. The feature couldn't be removed in e19 due to the policy of not removing features that aren't advertised in advance in Breaking Changes, so it was listed in e19 and is being removed now for e20.
See #33226 for more information.
CC @electron/wg-releases
Checklist
npm test
passesRelease Notes
Notes: Removed the skip-taskbar feature on Linux.