Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove skip-taskbar feature on Linux. #35123

Merged
merged 2 commits into from Aug 1, 2022

Conversation

ckerr
Copy link
Member

@ckerr ckerr commented Jul 29, 2022

Description of Change

This doesn't work in Wayland and won't be fixed. The feature couldn't be removed in e19 due to the policy of not removing features that aren't advertised in advance in Breaking Changes, so it was listed in e19 and is being removed now for e20.

See #33226 for more information.

CC @electron/wg-releases

Checklist

Release Notes

Notes: Removed the skip-taskbar feature on Linux.

Marked as unsupported in e19, now removed in e20.

See #33226 for more information
@ckerr ckerr added platform/linux semver/patch backwards-compatible bug fixes target/20-x-y labels Jul 29, 2022
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 29, 2022
@deepak1556
Copy link
Member

Should we also remove support of https://github.com/electron/electron/blob/main/docs/api/browser-window.md#winsetskiptaskbarskip for linux ? Looks like #33226 did not cover this.

@codebytere
Copy link
Member

codebytere commented Jul 29, 2022

@ckerr we should remove this note about linux here too:

`skipTaskbar: true`. On Linux setting `focusable: false` makes the window
stop interacting with wm, so the window will always stay on top in all
workspaces.

@VerteDinde VerteDinde force-pushed the fix/remove-skip-taskbar-on-linux branch from c87820d to f75a353 Compare July 29, 2022 19:10
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 30, 2022
@codebytere codebytere merged commit b67c69d into main Aug 1, 2022
@codebytere codebytere deleted the fix/remove-skip-taskbar-on-linux branch August 1, 2022 10:42
@release-clerk
Copy link

release-clerk bot commented Aug 1, 2022

Release Notes Persisted

Removed the skip-taskbar feature on Linux.

@trop
Copy link
Contributor

trop bot commented Aug 1, 2022

I have automatically backported this PR to "20-x-y", please check out #35156

@deepak1556
Copy link
Member

@codebytere the comment #35123 (comment) still holds true, https://github.com/electron/electron/blob/main/shell/browser/native_window_views.cc#L1043-L1047 supports the feature via win.setSkipTaskbar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/linux semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants