fix: fail non-fatally when InitLogging fails #35138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VerteDinde
approved these changes
Jul 29, 2022
|
When initializing logging fails, how does |
codebytere
approved these changes
Aug 1, 2022
3 tasks
|
Merging as CI failure unrelated to PR change. |
|
Release Notes Persisted
|
|
I have automatically backported this PR to "20-x-y", please check out #35190 |
schetle
pushed a commit
to schetle/electron
that referenced
this pull request
Nov 3, 2022
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some apps use logging in production to collect data in the wild. However,
there's no way for such apps to recover from a situation in which logging fails
(e.g. if the log file location is not accessible).
Instead of crashing, log (?) an error and continue.
Notes: Do not exit when logging initialization fails.