Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove skip-taskbar feature on Linux. #35156

Merged
merged 2 commits into from Aug 1, 2022
Merged

fix: remove skip-taskbar feature on Linux. #35156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbd8777
fix: remove skip-taskbar feature on Linux.
ckerr Jul 29, 2022
4d09162
docs: remove skipTaskbar note in browserWindow
VerteDinde Jul 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/api/browser-window.md
View file
Open in desktop
Expand Up @@ -1323,7 +1323,7 @@ win.setSheetOffset(toolbarRect.height)

Starts or stops flashing the window to attract user's attention.

#### `win.setSkipTaskbar(skip)`
#### `win.setSkipTaskbar(skip)` _macOS_ _Windows_

* `skip` boolean

Expand Down
5 changes: 0 additions & 5 deletions shell/browser/native_window_views.cc
View file
Open in desktop
Expand Up @@ -303,14 +303,9 @@ NativeWindowViews::NativeWindowViews(const gin_helper::Dictionary& options,

#if defined(USE_OZONE_PLATFORM_X11)
if (IsX11()) {
// TODO(ckerr): remove in Electron v20.0.0
// Before the window is mapped the SetWMSpecState can not work, so we have
// to manually set the _NET_WM_STATE.
std::vector<x11::Atom> state_atom_list;
bool skip_taskbar = false;
if (options.Get(options::kSkipTaskbar, &skip_taskbar) && skip_taskbar) {
state_atom_list.push_back(x11::GetAtom("_NET_WM_STATE_SKIP_TASKBAR"));
}

// Before the window is mapped, there is no SHOW_FULLSCREEN_STATE.
if (fullscreen) {
Expand Down