Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Wayland general CSD fixes #35206

Merged
merged 4 commits into from Aug 4, 2022

Commits on Aug 3, 2022

  1. fix: broken wayland window decorations due to botched chromium update

    The `GetTitlebarBounds().height()` is obviously intended to be placed in
    the `top` parameter, which used to be the second one before upstream
    removed multi-parameter `gfx::Rect::Inset`, but it's the first parameter
    for `gfx::Insets::TLBR`, which was intended to replace the removed
    `Inset` function. However, whoever updated Chromium kept the parameter
    unchanged, causing the title bar height to be passed to the `left`
    parameter, causing the window title bar to be unclickable.
    msizanoen1 committed Aug 3, 2022
    Copy the full SHA
    4c03038 View commit details
    Browse the repository at this point in the history
  2. fix: wayland window top bar buttons unclickable

    Use NonClientFrameView::TargetForRect for the ClientFrameViewLinux
    implementation because the default inherited from FramelessView blocks
    any non-HTCLIENT events.
    msizanoen1 committed Aug 3, 2022
    Copy the full SHA
    7729e40 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    b8bc941 View commit details
    Browse the repository at this point in the history
  4. fix: pass frame_->IsMaximized() to GetWindowFrameProvider

    This ensures that the toolkit renders the window decorations in maximized mode
    while the window is maximized to ensure that there is no empty space around the window.
    msizanoen1 committed Aug 3, 2022
    Copy the full SHA
    8d5adb9 View commit details
    Browse the repository at this point in the history