Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): fix a typo in section on debugging with VSCode #35256

Merged
merged 1 commit into from Aug 9, 2022

Conversation

bytrangle
Copy link
Contributor

@bytrangle bytrangle commented Aug 8, 2022

Description of Change

I just fixed a small typo in the section on debugging with VSCode

If you want to debug your application using VS Code, you have need attach VS Code to both the main and renderer processes.

to

If you want to debug your application using VS Code, you need to attach VS Code to both the main and renderer processes.

notes: Fixed a typo in the section on debugging with VSCode

Checklist

Release Notes

Notes:

notes: Fixed a typo in the section on debugging with VSCode

@welcome
Copy link

welcome bot commented Aug 8, 2022

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 8, 2022
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@codebytere codebytere added documentation 📓 target/19-x-y target/21-x-y PR should also be added to the "21-x-y" branch. labels Aug 8, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 9, 2022
@jkleinsc
Copy link
Contributor

jkleinsc commented Aug 9, 2022

Merging as CI failure unrelated to PR change.

@jkleinsc jkleinsc merged commit 32fefb1 into electron:main Aug 9, 2022
@welcome
Copy link

welcome bot commented Aug 9, 2022

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link

release-clerk bot commented Aug 9, 2022

Release Notes Persisted

Fixed a typo in the section on debugging with VSCode

@trop
Copy link
Contributor

trop bot commented Aug 9, 2022

I have automatically backported this PR to "19-x-y", please check out #35284

@trop
Copy link
Contributor

trop bot commented Aug 9, 2022

I have automatically backported this PR to "21-x-y", please check out #35285

@trop
Copy link
Contributor

trop bot commented Aug 9, 2022

I have automatically backported this PR to "20-x-y", please check out #35286

@trop trop bot added in-flight/21-x-y merged/21-x-y PR was merged to the "21-x-y" branch. and removed target/21-x-y PR should also be added to the "21-x-y" branch. target/20-x-y labels Aug 9, 2022
schetle pushed a commit to schetle/electron that referenced this pull request Nov 3, 2022
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📓 merged/21-x-y PR was merged to the "21-x-y" branch. semver/none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants