Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: undefined details.requestingUrl from session.setPermissionCheckHandler #35281

Merged
merged 1 commit into from Aug 23, 2022
Merged

fix: undefined details.requestingUrl from session.setPermissionCheckHandler #35281

merged 1 commit into from Aug 23, 2022

Conversation

deepak1556
Copy link
Member

@deepak1556 deepak1556 commented Aug 9, 2022 •
edited

Description of Change

With 7e59d78, https://chromium-review.googlesource.com/c/chromium/src/+/3495142 deprecates GetPermissionStatusForFrame in favor of GetPermissionStatusForCurrentDocument and the latter always called into GetPermissionStatus which does not have a frame context leading to empty RenderFrameHost causing the above issue.

Depends on #35292

Checklist

Release Notes

Notes: fix undefined details.requestingUrl from session.setPermissionCheckHandler

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 9, 2022
@deepak1556 deepak1556 added semver/patch backwards-compatible bug fixes target/19-x-y target/21-x-y PR should also be added to the "21-x-y" branch. labels Aug 9, 2022
miniak
miniak requested changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@miniak miniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the WebFrameMain::ExecuteJavaScript change should be a separate PR

@deepak1556 deepak1556 mentioned this pull request Aug 10, 2022
Merged
5 tasks
@deepak1556 deepak1556 force-pushed the robo/fix_permission_handler_details branch from 06f1491 to a8f0c4a Compare August 10, 2022 04:27
@deepak1556 deepak1556 requested a review from miniak August 10, 2022 04:27
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 10, 2022
@deepak1556 deepak1556 force-pushed the robo/fix_permission_handler_details branch from a8f0c4a to b63dc8e Compare August 17, 2022 15:17
@zcbenz zcbenz merged commit 33325e3 into main Aug 23, 2022
@zcbenz zcbenz deleted the robo/fix_permission_handler_details branch August 23, 2022 01:25
@release-clerk
Copy link

release-clerk bot commented Aug 23, 2022

Release Notes Persisted

fix undefined details.requestingUrl from session.setPermissionCheckHandler

@trop trop bot mentioned this pull request Aug 23, 2022
Closed
@trop
Copy link
Contributor

trop bot commented Aug 23, 2022

I have automatically backported this PR to "19-x-y", please check out #35407

This was referenced Aug 23, 2022
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Aug 23, 2022

I have automatically backported this PR to "20-x-y", please check out #35408

@trop
Copy link
Contributor

trop bot commented Aug 23, 2022

I have automatically backported this PR to "21-x-y", please check out #35409

@trop trop bot added merged/21-x-y PR was merged to the "21-x-y" branch. merged/20-x-y and removed target/21-x-y PR should also be added to the "21-x-y" branch. in-flight/21-x-y labels Aug 23, 2022
@commit-lint commit-lint bot mentioned this pull request Nov 14, 2022
Open
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@deepak1556 @khalwa
fix: undefined details.requestingUrl from session.setPermissionCheckH…
a0b6d55 
…andler (electron#35281)

fix: undefined details.requestingUrl from setPermissionCheckHandler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@miniak miniak miniak approved these changes

@codebytere codebytere codebytere approved these changes

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

Assignees
No one assigned
Labels
merged/21-x-y PR was merged to the "21-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@deepak1556 @zcbenz @miniak @codebytere