New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add Electron deps to license credits file #35283
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nan is not distributed by Electron, it's a test-only dependency
patches/chromium/add_electron_deps_to_license_credits_file.patch
Outdated
Show resolved
Hide resolved
remove nan; it is dev-only
Release Notes Persisted
|
I have automatically backported this PR to "19-x-y", please check out #35330 |
I have automatically backported this PR to "20-x-y", please check out #35331 |
I have automatically backported this PR to "21-x-y", please check out #35332 |
* docs: add Electron deps to license credits file * fixup! docs: add Electron deps to license credits file remove nan; it is dev-only
* docs: add Electron deps to license credits file * fixup! docs: add Electron deps to license credits file remove nan; it is dev-only
Description of Change
Ensure that dependencies introduced by Electron (i.e. not already in Chromium) are documented in the licenses file.
Checklist
npm test
passesRelease Notes
Notes: Added license statements for Squirrel, Node, and nan in releases