build: bump @electron/get to 2.0.0, node to >= 12+ #35301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VerteDinde
changed the title
erickzhao
approved these changes
Aug 10, 2022
|
🤔 shouldn't the notes state that the minimum version of Node.js needed to install Electron itself is now 12.0.0? |
|
@malept Yeah, you’re right - updated release notes with the exact version of 12 👍 |
malept
reviewed
Aug 10, 2022
There was a problem hiding this comment.
Nit: I think I read somewhere that the correct way to refer to the runtime is with the .js suffix.
-Notes: Bumps the minimum required version of Node needed to install Electron to 12.20.55
+Notes: Bumps the minimum required version of Node.js needed to install Electron to 12.20.55Otherwise 
malept
approved these changes
Aug 10, 2022
|
Release Notes Persisted
|
schetle
pushed a commit
to schetle/electron
that referenced
this pull request
Nov 3, 2022
* infra: bump @electron/get to 2.0.0, node to >= 12+ * chore: empty commit to trigger CircleCI
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
* infra: bump @electron/get to 2.0.0, node to >= 12+ * chore: empty commit to trigger CircleCI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Aligns our npm package with the newest version of @electron/get, and the new minimum version of Node that is required (see @electron/get PR here: electron/get#225 )
Checklist
npm testpassesRelease Notes
Notes: Bumps the minimum required version of Node.js needed to install Electron to 12.20.55